Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/arabic support #8422

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

BaytaX
Copy link

@BaytaX BaytaX commented Sep 20, 2024

add support for arabic letters so it goes from right to left

@BaytaX BaytaX requested a review from a team as a code owner September 20, 2024 15:11
Copy link

changeset-bot bot commented Sep 20, 2024

⚠️ No Changeset found

Latest commit: f64c11d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Sep 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 20, 2024 3:13pm

Copy link

vercel bot commented Sep 20, 2024

@BaytaX is attempting to deploy a commit to the toeverything Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

graphite-app bot commented Sep 20, 2024

Your org has enabled the Graphite merge queue for merging into master

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link

nx-cloud bot commented Sep 20, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit f64c11d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@Saul-Mirone
Copy link
Collaborator

Saul-Mirone commented Sep 20, 2024

We don't plan to do this in such a pattern. Basically you need to modify every single block with text. Which is unacceptable. And it also doesn't consider features in whiteboard and database. RTL is an important feature and need to be carefully designed.

@BaytaX
Copy link
Author

BaytaX commented Sep 20, 2024

okay got it but i need it for a project i work on so how's that possible to modify in the editor and import from the one who i change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants